Hi Dan, Do you plan to send v2 of this patch set? https://lkml.org/lkml/2020/1/31/1 I'm preparing my patch set on top of this. Hence the query. Thanks Calvin On Mon, Feb 03, 2020 at 05:11:49AM +0000, kbuild test robot wrote: > Hi Dan, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net/master] > [also build test WARNING on driver-core/driver-core-testing linus/master v5.5 next-20200131] > [cannot apply to sparc-next/master] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Dan-Carpenter/device-property-change-device_get_phy_mode-to-prevent-signedess-bugs/20200203-043126 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git b7c3a17c6062701d97a0959890a2c882bfaac537 > reproduce: > # apt-get install sparse > # sparse version: v0.6.1-154-g1dc00f87-dirty > make ARCH=x86_64 allmodconfig > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > > sparse warnings: (new ones prefixed by >>) > > arch/x86/boot/compressed/cmdline.c:5:20: sparse: sparse: multiple definitions for function 'set_fs' > >> arch/x86/include/asm/uaccess.h:29:20: sparse: the previous one is here > arch/x86/boot/compressed/../cmdline.c:28:5: sparse: sparse: symbol '__cmdline_find_option' was not declared. Should it be static? > arch/x86/boot/compressed/../cmdline.c:100:5: sparse: sparse: symbol '__cmdline_find_option_bool' was not declared. Should it be static? > > vim +29 arch/x86/include/asm/uaccess.h > > ca23386216b9d4 include/asm-x86/uaccess.h Glauber Costa 2008-06-13 27 > 13d4ea097d18b4 arch/x86/include/asm/uaccess.h Andy Lutomirski 2016-07-14 28 #define get_fs() (current->thread.addr_limit) > 5ea0727b163cb5 arch/x86/include/asm/uaccess.h Thomas Garnier 2017-06-14 @29 static inline void set_fs(mm_segment_t fs) > 5ea0727b163cb5 arch/x86/include/asm/uaccess.h Thomas Garnier 2017-06-14 30 { > 5ea0727b163cb5 arch/x86/include/asm/uaccess.h Thomas Garnier 2017-06-14 31 current->thread.addr_limit = fs; > 5ea0727b163cb5 arch/x86/include/asm/uaccess.h Thomas Garnier 2017-06-14 32 /* On user-mode return, check fs is correct */ > 5ea0727b163cb5 arch/x86/include/asm/uaccess.h Thomas Garnier 2017-06-14 33 set_thread_flag(TIF_FSCHECK); > 5ea0727b163cb5 arch/x86/include/asm/uaccess.h Thomas Garnier 2017-06-14 34 } > ca23386216b9d4 include/asm-x86/uaccess.h Glauber Costa 2008-06-13 35 > > :::::: The code at line 29 was first introduced by commit > :::::: 5ea0727b163cb5575e36397a12eade68a1f35f24 x86/syscalls: Check address limit on user-mode return > > :::::: TO: Thomas Garnier <thgarnie@xxxxxxxxxx> > :::::: CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
