On Mon, Mar 09, 2020 at 07:32:10AM +0100, Lukas Bulwahn wrote: > > > On Sun, 8 Mar 2020, Joe Perches wrote: > > > On Sun, 2020-03-08 at 15:32 -0700, Guenter Roeck wrote: > > > On Sun, Mar 8, 2020 at 12:51 PM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: > > > > All files in drivers/firmware/google/ are identified as part of THE REST > > > > according to MAINTAINERS, but they are really maintained by others. > > [] > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > [] > > > > @@ -7111,6 +7111,14 @@ S: Supported > > > > F: Documentation/networking/device_drivers/google/gve.rst > > > > F: drivers/net/ethernet/google > > > > > > > > +GOOGLE FIRMWARE > > > > +M: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > +M: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > > > +R: Guenter Roeck <groeck@xxxxxxxxxxxx> > > > > +R: Julius Werner <jwerner@xxxxxxxxxxxx> > > > > +S: Maintained > > > > +F: drivers/firmware/google/ > > > > + > > > > > > FWIW, I would not mind stepping up as maintainer if needed, but I > > > think we should strongly discourage this kind of auto-assignment of > > > maintainers and/or reviewers. > > > > Auto assignment should definitely _not_ be done. > > > > This is an RFC proposal though. > > > > Sometimes it's better to not produce an RFC as > > a patch, but maybe just show a proposed section > > and ask if is appropriate may be a better style > > going forward. > > > > Please interpret the RFC patch similar to an email as Joe wrote below, > simply reaching out to you. > > There is no auto-assignment intended, nor did I expect the patch to be > picked up on the first attempt of uneducated guessing. > > There are currently around 3,000 files identified being part of THE REST; > so they are all assigned to Linus and LKML. > > To confirm that they actually are maintained by someone else and reflect > that in MAINTAINERS, a bit of educated guessing who to contact and to > which entry to add the files to is required. > > I am starting with the "bigger" clustered files in drivers, and then try > to look at files in include and Documentation/ABI/. > > Here is a rough statistics on how many files from each directory are in > THE REST: > > 1368 include > 566 tools > 327 lib > 321 Documentation > 100 drivers > 91 kernel > 84 scripts > 75 samples > 13 ipc > 13 init > 8 usr > 2 arch > 1 virt When you use the get_maintainer.pl script, it should find reasonable people/lists for those files, so why not just stick with that? Trying to classify all of the kernel files to have MAINTAINERS entries seems like a loosing proposition as there are file that no one has touched in years. thanks, greg k-h
