Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-03-04 at 17:22 +0300, Dan Carpenter wrote:
> The esw_vport_tbl_get() function returns error pointers on error.
> 
> Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> mirroring")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Hi Dan the patch looks fine, but you didn't cc netdev mailing list
Two options:

1) I can pick this patch up and repost it myself in a future pull
request
2) you can re-post it and cc netdev also mark it for net [PATCH net]

let me know what you prefer.

Thanks,
Saeed.


> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> index 4b5b6618dff4..692fe9e6a08f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> @@ -198,7 +198,7 @@ int mlx5_esw_vport_tbl_get(struct mlx5_eswitch
> *esw)
>  	mlx5_esw_for_all_vports(esw, i, vport) {
>  		attr.in_rep->vport = vport->vport;
>  		fdb = esw_vport_tbl_get(esw, &attr);
> -		if (!fdb)
> +		if (IS_ERR(fdb))
>  			goto out;
>  	}
>  	return 0;




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux