Re: [PATCH v2] drm/amd/display: Fix dmub_psr_destroy()

["Kazlauskas, Nicholas" <nicholas.kazlauskas@xxxxxxx>]

On 2020-02-28 5:58 a.m., Dan Carpenter wrote:
> This is freeing the wrong variable so it will crash.  It should be
> freeing "*dmub" instead of "dmub".
>
> Fixes: 4c1a1335dfe0 ("drm/amd/display: Driverside changes to support PSR in DMCUB")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>

Thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
> index 2c932c29f1f9..f0936cb3c056 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
> @@ -235,6 +235,6 @@ struct dmub_psr *dmub_psr_create(struct dc_context *ctx)
>    */
>   void dmub_psr_destroy(struct dmub_psr **dmub)
>   {
> -	kfree(dmub);
> +	kfree(*dmub);
>   	*dmub = NULL;
>   }