On Wed, Feb 5, 2020 at 3:56 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > The bug is that we call kfree_skb(skb) and then pass "skb" to > qdisc_pkt_len(skb) on the next line, which is a use after free. > Also Cong Wang points out that it's better to delay the actual > frees until we drop the rtnl lock so we should use rtnl_kfree_skbs() > instead of kfree_skb(). > > Cc: Cong Wang <xiyou.wangcong@xxxxxxxxx> > Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Cong Wang <xiyou.wangcong@xxxxxxxxx> Thanks!