On Tue, Jan 21, 2020 at 03:13:29PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On 1/21/20 2:06 PM, Dan Carpenter wrote: > > The IDE core always sets ->dn correctly so changing it is never > > required. > > > > Setting it to a different value than assigned by IDE core is very likely > > to result in data corruption (due to wrong transfer timings being set on > > the controller etc.) > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Thanks, it looks fine (though patch summary can be improved further i.e.: > "[PATCH] ide-proc: make "number" setting read-only"). > > Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > I've also verified it (using ARAnyM emulator): > > Tested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > Thanks! regards, dan carpenter
