Thanks for taking a look at the code and your feedback on the driver! On Wed, Jan 15, 2020 at 08:45:31PM +0300, Dan Carpenter wrote: > We put an upper bound on "val2" but we also need to prevent negative > values. "val" is not used past the invalid value check. We only use "val" to make sure that it is in fact 0. AFAIK there is no "upper bound" on "val", it should be zero or we return -EINVAL. Am I missing something? Cheers, - Dan
