On 14/01/2020 12:01, Borislav Petkov wrote: > On Tue, Jan 14, 2020 at 11:51:43AM +0000, Colin Ian King wrote: >> Starting at load_ucode_amd_bsp(), this initializes a local cp to zero, >> then passes &cp when it calls __load_ucode_amd() as parameter *ret. In >> __load_ucode_amd a new local cp is created on the stack and *only* is >> assigned here: >> >> if (!get_builtin_microcode(&cp, x86_family(cpuid_1_eax))) >> cp = find_microcode_in_initrd(path, use_pa); > > Is there any case where cp doesn't get assigned here? Either by > get_builtin_microcode() or by find_microcode_in_initrd()? > >> I can send a V2 w/o these if it so pleases you. I've had nobody else >> complain about these and we have literally hundreds of Coverity tagged >> issues now accepted in the kernel so that we can trace how fixes are >> found. > > Who's "we" and how can "we" trace them? When I see Addresses-Coverity: > how can I trace how a fix is found? How can I find out what that tag > even means? > > All I'm asking is to document how one can find out what that tag means > and how it can be used by people looking at that commit message. OK, I will try to extract every special Tag from Coverity and get this documented when I get some spare cycles. > > Thx. >
