On Fri, 2020-01-10 at 08:52 +0300, Dan Carpenter wrote: > drivers/regulator/mp8859.c I suggest also removing the blank line before this block and adding a blank line after... --- drivers/regulator/mp8859.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index e804a5..87986d 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -118,13 +118,13 @@ static int mp8859_i2c_probe(struct i2c_client *i2c) } rdev = devm_regulator_register(&i2c->dev, &mp8859_regulators[0], &config); - if (IS_ERR(rdev)) { ret = PTR_ERR(rdev); dev_err(&i2c->dev, "failed to register %s: %d\n", mp8859_regulators[0].name, ret); - return ret; - } + return ret; + } + return 0; }