Re: [PATCH net-next] ethtool: fix ->reply_size() error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: dan.carpenter@xxxxxxxxxx
Subject: Re: [PATCH net-next] ethtool: fix ->reply_size() error handling
From: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed, 08 Jan 2020 16:03:59 -0800 (PST)
Cc: mkubecek@xxxxxxx, f.fainelli@xxxxxxxxx, andrew@xxxxxxx, netdev@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20200108054125.feeckqg6xhab3wam@kili.mountain>
References: <20200108054125.feeckqg6xhab3wam@kili.mountain>

From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Wed, 8 Jan 2020 08:41:25 +0300

> The "ret < 0" comparison is never true because "ret" is still zero.
> 
> Fixes: 728480f12442 ("ethtool: default handlers for GET requests")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied.

References:
- [PATCH net-next] ethtool: fix ->reply_size() error handling
  - From: Dan Carpenter

Prev by Date: Re: [PATCH net-next] ethtool: fix a memory leak in ethnl_default_start()
Next by Date: Re: [PATCH] ethtool: potential NULL dereference in strset_prepare_data()
Previous by thread: Re: [PATCH net-next] ethtool: fix ->reply_size() error handling
Next by thread: [PATCH] ethtool: potential NULL dereference in strset_prepare_data()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux