Re: [PATCH] net/rose: remove redundant assignment to variable failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Colin King <colin.king@xxxxxxxxxxxxx>
Subject: Re: [PATCH] net/rose: remove redundant assignment to variable failed
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 7 Jan 2020 19:32:02 +0300
Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, linux-hams@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20200107161827.GO3911@kadam>
References: <20200107152415.106353-1-colin.king@canonical.com> <20200107161827.GO3911@kadam>
User-agent: Mutt/1.9.4 (2018-02-28)

Never mind.  I misread what the code is doing.  Your patch is correct.
My patch would have been harmless but made the code even more confusing.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter

References:
- [PATCH] net/rose: remove redundant assignment to variable failed
  - From: Colin King
- Re: [PATCH] net/rose: remove redundant assignment to variable failed
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] net/rose: remove redundant assignment to variable failed
Next by Date: Re: [PATCH 2/4] vfio: vfio_pci_nvlink2: use mmgrab
Previous by thread: Re: [PATCH] net/rose: remove redundant assignment to variable failed
Next by thread: Re: [PATCH] net/rose: remove redundant assignment to variable failed
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux