On 04/12/2019 15:28:26+0800, Mao Wenan wrote: > rtc->irq is requested by devm_request_threaded_irq, > and request_threaded_irq. IRQs requested with this > function will be automatically freed on driver detach. > This patch remove unused error label as well. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx> > --- > v2: remove error label as Dan Carpenter suggest. > drivers/rtc/rtc-mt6397.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index 5249fc99fd5f..14f3c4915260 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -287,13 +287,6 @@ static int mtk_rtc_probe(struct platform_device *pdev) > rtc->rtc_dev->ops = &mtk_rtc_ops; > > ret = rtc_register_device(rtc->rtc_dev); > - if (ret) > - goto out_free_irq; > - > - return 0; > - > -out_free_irq: > - free_irq(rtc->irq, rtc); > return ret; Maybe return rtc_register_device(rtc->rtc_dev); > } > > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
