From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Tue, 26 Nov 2019 15:18:54 +0300 > This code is harmless but it triggers a Smatch static checker warning: > > net/dsa/tag_8021q.c:108 dsa_8021q_restore_pvid() > error: uninitialized symbol 'pvid'. > > I believe that UBSan will complain at run time as well. The solution is > to just re-order the conditions. > > Fixes: c80ed84e7688 ("net: dsa: tag_8021q: Fix dsa_8021q_restore_pvid for an absent pvid") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> THis doesn't apply to the current net tree.