On Mon, 18 Nov 2019, Travis Davies wrote: > Signed-off-by: Travis Davies <tdavies@xxxxxxxxxxxxxxx> > > --- > > This patch places /* and */ on separate lines for a > multiline block comment, in order to keep code style > consistant with majority of blocks throughout the file. > > This will prevent a checkpatch.pl warning: > 'Block comments use a trailing */ on a separate line' The comments and the signed off by both go above the ---. Comments first. Look at lkml to see what others do. julia > > include/linux/netdevice.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index c20f190b4c18..a2605e043fa2 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -95,9 +95,11 @@ void netdev_set_default_ethtool_ops(struct net_device *dev, > #define NET_XMIT_CN 0x02 /* congestion notification */ > #define NET_XMIT_MASK 0x0f /* qdisc flags in net/sch_generic.h */ > > -/* NET_XMIT_CN is special. It does not guarantee that this packet is lost. It > +/* > + * NET_XMIT_CN is special. It does not guarantee that this packet is lost. It > * indicates that the device will soon be dropping packets, or already drops > - * some packets of the same priority; prompting us to send less aggressively. */ > + * some packets of the same priority; prompting us to send less aggressively. > + */ > #define net_xmit_eval(e) ((e) == NET_XMIT_CN ? 0 : (e)) > #define net_xmit_errno(e) ((e) != NET_XMIT_CN ? -ENOBUFS : 0) > > -- > 2.21.0 > >
