From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Wed, 13 Nov 2019 21:31:58 +0300 > irqreturn_t type is an enum and in this context it's unsigned, so "err" > can't be irqreturn_t or it breaks the error handling. In fact the "err" > variable is only used to store integers (never irqreturn_t) so it should > be declared as int. > > I removed the initialization because it's not required. Using a bogus > initializer turns off GCC's uninitialized variable warnings. Secondly, > there is a GCC warning about unused assignments and we would like to > enable that feature eventually so we have been trying to remove these > unnecessary initializers. > > Fixes: 7b0c342f1f67 ("net: atlantic: code style cleanup") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied.