Re: s390/pkey: Use memdup_user() rather than duplicating its implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06.11.19 14:00, Markus Elfring wrote:
>>> Reuse existing functionality from memdup_user() instead of keeping
>>> duplicate source code.
>>>
>>> Generated by: scripts/coccinelle/api/memdup_user.cocci
> …
>>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
>>
>> This doesn't fix anything
> 
> How would you categorise the proposed source code reduction and software reuse?

Cleanup.

Can you please stop arguing about review feedback that is clearly right? This is not fixing 
anything. The Fixes tag is used to decide if something needs a backport. And every backport has 
a chance for a regression. So adding a Fixes tag to something that is not fixing a bug is actually
hurting. 




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux