> -----Original Message-----
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> Sent: Wednesday, November 6, 2019 9:25 PM
> To: Radhey Shyam Pandey <radheys@xxxxxxxxxx>; Michal Simek
> <michals@xxxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; Robert Hancock
> <hancock@xxxxxxxxxxxxx>
> Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> arm-kernel@xxxxxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH net-next] net: axienet: Fix error return code in axienet_probe()
>
> In the DMA memory resource get failed case, the error is not
> set and 0 will be returned. Fix it by reove redundant check
:s/reove/removing
> since devm_ioremap_resource() will handle it.
>
> Fixes: 28ef9ebdb64c ("net: axienet: make use of axistream-connected attribute
> optional")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
The rest looks fine.
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 867726d696e2..8f32db6d2c45 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1788,10 +1788,6 @@ static int axienet_probe(struct platform_device
> *pdev)
> /* Check for these resources directly on the Ethernet node. */
> struct resource *res = platform_get_resource(pdev,
>
> IORESOURCE_MEM, 1);
> - if (!res) {
> - dev_err(&pdev->dev, "unable to get DMA memory
> resource\n");
> - goto free_netdev;
> - }
> lp->dma_regs = devm_ioremap_resource(&pdev->dev, res);
> lp->rx_irq = platform_get_irq(pdev, 1);
> lp->tx_irq = platform_get_irq(pdev, 0);
>
>
