On Saturday 2 November 2019 16:59:45 CET Christophe JAILLET wrote: > The current code is a no-op, because all it can do is 'dev_kfree_skb(NULL)' > Remove the test before 'dev_kfree_skb()' > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > V2: remove the 'if(...)', 'dev_kfree_skb()' can handle NULL. > --- > drivers/staging/wfx/sta.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c > index 688586e823c0..93f3739b5f3a 100644 > --- a/drivers/staging/wfx/sta.c > +++ b/drivers/staging/wfx/sta.c > @@ -906,8 +906,7 @@ static int wfx_upload_beacon(struct wfx_vif *wvif) > wfx_fwd_probe_req(wvif, false); > > done: > - if (!skb) > - dev_kfree_skb(skb); > + dev_kfree_skb(skb); > return ret; > } > > -- > 2.20.1 > In add, value of skb is tested earlier in function. So, it is guaranteed to be never NULL. Reviewed-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> -- Jérôme Pouiller
