> If rndis_filter_open() fails, we need to remove the rndis device created > in earlier steps, before returning an error code. Otherwise, the retry of > netvsc_attach() from its callers will fail and hang. How do you think about to choose a more “imperative mood” for your change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=0dbe6cb8f7e05bc9611602ef45980a6c57b245a3#n151 … > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -982,7 +982,7 @@ static int netvsc_attach(struct net_device *ndev, > if (netif_running(ndev)) { > ret = rndis_filter_open(nvdev); > if (ret) > - return ret; > + goto err; > > rdev = nvdev->extension; > if (!rdev->link_state) … I would prefer to specify the completed exception handling (addition of two function calls) by a compound statement in the shown if branch directly. If you would insist to use a goto statement, I find an other label more appropriate according to the Linux coding style. Regards, Markus
