On Fri, Nov 01, 2019 at 09:36:27AM -0400, Chuck Lever wrote:
> Hi Mao-
>
> > On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@xxxxxxxxxx> wrote:
> >
> > The declarations were introduced with the file, but the declared
> > variables were not used.
> >
> > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
>
> I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
> works fine without this change, and it's not something we
> would need to backport into stable kernels.
>
> This is more of a clean up patch.
>
Fixes is not really related to backports or stable. I would agree that
this isn't a bug but just a cleanup, but the problem is that other
people want Fixes tags for everything...
Yesterday I sent a cleanup patch and I almost put the Fixes tag under
the --- cut off but in the end I just deleted it... It's hard to know
what the right thing is.
regards,
dan carpenter
