Re: [PATCH] drm/tinydrm: Fix memroy leak in hx8357d_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



…
> +++ b/drivers/gpu/drm/tiny/hx8357d.c
> @@ -232,44 +232,49 @@ static int hx8357d_probe(struct spi_device *spi)
…
> +		goto free_dbidev;
>
>  	spi_set_drvdata(spi, drm);

I got another development concern here.
Can it make sense to pass the variable “dbidev” instead of “drm”?


…
> +free_dbidev:
> +	kfree(dbidev);
…

I became curious if there is a need for such a memory release at another place.
How do you think about to add this function call also to the implementation
of the function “hx8357d_remove”?

Regards,
Markus




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux