RE: [EXT] [PATCH] net: fec: remove redundant assignment to pointer bdp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Colin King <colin.king@xxxxxxxxxxxxx> Sent: Saturday, October 26, 2019 1:23 AM
> The pointer bdp is being assigned with a value that is never read, so the
> assignment is redundant and hence can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Thanks.

Acked-by: Fugang Duan <fugang.duan@xxxxxxx>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d4d4c72adf49..608196bdd892 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2706,7 +2706,6 @@ static void fec_enet_free_buffers(struct
> net_device *ndev)
> 
>         for (q = 0; q < fep->num_tx_queues; q++) {
>                 txq = fep->tx_queue[q];
> -               bdp = txq->bd.base;
>                 for (i = 0; i < txq->bd.ring_size; i++) {
>                         kfree(txq->tx_bounce[i]);
>                         txq->tx_bounce[i] = NULL;
> --
> 2.20.1





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux