Re: [PATCH] ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency

Tzung-Bi Shih <tzungbi@xxxxxxxxxx> · Wed, 23 Oct 2019 16:03:07 +0800

On Wed, Oct 23, 2019 at 2:31 PM Mao Wenan <maowenan@xxxxxxxxxx> wrote:
>
> If SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A=y,
> below errors can be seen:
> sound/soc/codecs/cros_ec_codec.o: In function `send_ec_host_command':
> cros_ec_codec.c:(.text+0x534): undefined reference to `cros_ec_cmd_xfer_status'
> cros_ec_codec.c:(.text+0x101c): undefined reference to `cros_ec_get_host_event'
>
> This is because it will select SND_SOC_CROS_EC_CODEC
> after commit 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV"),
> but SND_SOC_CROS_EC_CODEC depends on CROS_EC.
>
> Fixes: 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV")
> Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>

Acked-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>

Thanks for the catching.