> …
>> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
>> @@ -557,13 +557,16 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
> …
>> if (ret) {
>> v3d_job_put(&render->base);
>> + kfree(bin);
> …
>
> Can it be helpful to move the added function call before the other
> in this if branch (if you prefer to avoid the addition of a jump target here)?
I got into the mood to take another look at these implementation details.
I suggest then to look at the commit 0d352a3a8a1f26168d09f7073e61bb4b328e3bb9
("drm/v3d: don't leak bin job if v3d_job_init fails." from 2019-09-18)
once more.
With which software versions did you perform your source code analysis?
Regards,
Markus
