On Sat, Oct 12, 2019 at 07:03:09PM +0200, Markus Elfring wrote: > Hello, > > I tried another script for the semantic patch language out. > This source code analysis approach points out that the implementation > of the function “de21041_get_srom_info” contains still an unchecked call > of the function “kmemdup”. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/dec/tulip/de2104x.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1940 > https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/net/ethernet/dec/tulip/de2104x.c#L1940 > > How do you think about to improve it? If i have not missed a place, the only user is de_get_eeprom(), which checks whether de->ee_data is valid. So i think although not obvious, there's no problem here. Regards Sven
