On Wed, Oct 9, 2019 at 9:27 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Wed, 9 Oct 2019 09:13:17 -0700 > Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > > On Wed, Oct 9, 2019 at 8:09 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > > > I'm curious. How many warnings showed up when you applied this patch? > > > > I got zero for x86_64 and arm64 defconfig builds of linux-next with > > this applied. Hopefully that's not an argument against the more > > liberal application of it? I view __must_check as a good thing, and > > encourage its application, unless someone can show that a certain > > function would be useful to call without it. > > Not at all, I was just curious, because I would have expected patches > to fix possible bugs with it. Ah, granted, I was surprised, too. Maybe would be helpful to mention that in the commit message. -- Thanks, ~Nick Desaulniers
