On Wed, Oct 09, 2019 at 12:06:21PM +0000, YueHaibing wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> Acked-by: Antoine Tenart <antoine.tenart@xxxxxx> Thanks, Antoine > --- > drivers/crypto/inside-secure/safexcel_hash.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secure/safexcel_hash.c > index 85c3a075f283..a07a2915fab1 100644 > --- a/drivers/crypto/inside-secure/safexcel_hash.c > +++ b/drivers/crypto/inside-secure/safexcel_hash.c > @@ -2109,10 +2109,7 @@ static int safexcel_xcbcmac_cra_init(struct crypto_tfm *tfm) > > safexcel_ahash_cra_init(tfm); > ctx->kaes = crypto_alloc_cipher("aes", 0, 0); > - if (IS_ERR(ctx->kaes)) > - return PTR_ERR(ctx->kaes); > - > - return 0; > + return PTR_ERR_OR_ZERO(ctx->kaes); > } > > static void safexcel_xcbcmac_cra_exit(struct crypto_tfm *tfm) > > > > > -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com