On 10/5/19 11:23 AM, Colin Ian King wrote: > On 05/10/2019 19:10, Randy Dunlap wrote: >> On 10/5/19 10:58 AM, Colin King wrote: >>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> >>> >>> Function kgd2kfd_init is missing a void argument, add it >>> to clean up the non-ANSI function declaration. >>> >>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> >> >> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> >> sparse reports 2 such warnings in amdgpu: >> >> ../drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_module.c:85:18: warning: non-ANSI function declaration of function 'kgd2kfd_init' >> ../drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c:168:60: warning: non-ANSI function declaration of function 'amdgpu_amdkfd_gfx_10_0_get_functions' > > Looking at linux-next, the amdgpu_amdkfd_gfx_10_0_get_functions() was > removed in commit: > > commit e392c887df979112af94cfec08dd87f4dd55d085 > Author: Yong Zhao <Yong.Zhao@xxxxxxx> > Date: Fri Sep 27 22:03:42 2019 -0400 > > drm/amdkfd: Use array to probe kfd2kgd_calls > > ..so I didn't fix that one up ah. Thanks. -- ~Randy
