Re: [PATCH] nl80211: fix memory leak in nl80211_get_ftm_responder_stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] nl80211: fix memory leak in nl80211_get_ftm_responder_stats
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Sat, 5 Oct 2019 17:35:44 +0200
Cc: Navid Emamdoost <emamd001@xxxxxxx>, Kangjie Lu <kjlu@xxxxxxx>, Stephen McCamant <smccaman@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20191004194220.19412-1-navid.emamdoost@gmail.com>
References: <20191004194220.19412-1-navid.emamdoost@gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

> In nl80211_get_ftm_responder_stats, a new skb is created via nlmsg_new
> named msg. If nl80211hdr_put() fails, then msg should be released. The
> return statement should be replace by goto to error handling code.

Please improve this change description (also by avoiding a typo).

Regards,
Markus

Prev by Date: Re: [PATCH] crypto: user - fix memory leak in crypto_reportstat
Next by Date: Re: [PATCH] rtlwifi: fix memory leak in rtl_usb_probe
Previous by thread: Re: [PATCH] crypto: user - fix memory leak in crypto_reportstat
Next by thread: Re: [PATCH] rtlwifi: fix memory leak in rtl_usb_probe
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux