Re: [PATCH] scsi: fnic: make array dev_cmd_err static const, makes object smaller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Colin King <colin.king@xxxxxxxxxxxxx>
Subject: Re: [PATCH] scsi: fnic: make array dev_cmd_err static const, makes object smaller
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 30 Sep 2019 22:46:07 -0400
Cc: Satish Kharat <satishkh@xxxxxxxxx>, Sesidhar Baddela <sebaddel@xxxxxxxxx>, Karan Tilak Kumar <kartilak@xxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20190906163945.3889-1-colin.king@canonical.com> (Colin King's message of "Fri, 6 Sep 2019 17:39:45 +0100")
Organization: Oracle Corporation
References: <20190906163945.3889-1-colin.king@canonical.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

Colin,

> Don't populate the array dev_cmd_err on the stack but instead make it
> static const. Makes the object code smaller by 80 bytes.

Applied to 5.5/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH] scsi: fnic: make array dev_cmd_err static const, makes object smaller
  - From: Colin King

Prev by Date: Re: [PATCH] scsi: ufs: make array setup_attrs static const, makes object smaller
Next by Date: Re: [PATCH] phy-brcm-usb: Use devm_platform_ioremap_resource() in brcm_usb_phy_probe()
Previous by thread: [PATCH] scsi: fnic: make array dev_cmd_err static const, makes object smaller
Next by thread: [PATCH] scsi: ips: make array 'options' static const, makes object smaller
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux