+Cc linux-amlogic mailing list On Wed, Sep 25, 2019 at 12:59 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > The "dwmac->phy_mode" is an enum and in this context GCC treats it as > an unsigned int so the error handling is never triggered. > > Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> thank you for catching and fixing this! Martin