> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Wednesday, September 25, 2019 4:29 PM
> To: Radhey Shyam Pandey <radheys@xxxxxxxxxx>; Alvaro G. M
> <alvaro.gamez@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Michal Simek
> <michals@xxxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH net] net: axienet: fix a signedness bug in probe
>
> The "lp->phy_mode" is an enum but in this context GCC treats it as an
> unsigned int so the error handling is never triggered.
>
> Fixes: ee06b1728b95 ("net: axienet: add support for standard phy-mode
> binding")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 4fc627fb4d11..676006f32f91 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1762,7 +1762,7 @@ static int axienet_probe(struct platform_device
> *pdev)
> }
> } else {
> lp->phy_mode = of_get_phy_mode(pdev->dev.of_node);
> - if (lp->phy_mode < 0) {
> + if ((int)lp->phy_mode < 0) {
> ret = -EINVAL;
> goto free_netdev;
> }
> --
> 2.20.1
