From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Fri, 20 Sep 2019 10:52:56 +0200 Simplify this function implementation by using the wrapper function “devm_platform_ioremap_resource” instead of calling the functions “platform_get_resource” and “devm_ioremap_resource” directly. * Thus reduce also a bit of exception handling code here. * Delete the local variable “res”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- v2: Further changes were requested by Radhey Shyam Pandey. https://lore.kernel.org/r/CH2PR02MB700047AFFFE08FE5FD563541C78E0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ * Updates for three modules were split into a separate patch for each driver. * The commit description was adjusted. drivers/net/ethernet/cortina/gemini.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index e736ce2c58ca..f009415ee4d8 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -2549,17 +2549,13 @@ static int gemini_ethernet_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct gemini_ethernet *geth; unsigned int retry = 5; - struct resource *res; u32 val; /* Global registers */ geth = devm_kzalloc(dev, sizeof(*geth), GFP_KERNEL); if (!geth) return -ENOMEM; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - geth->base = devm_ioremap_resource(dev, res); + geth->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(geth->base)) return PTR_ERR(geth->base); geth->dev = dev; -- 2.23.0
