On Thu, Sep 05, 2019 at 03:23:21PM +0300, Oleh Kravchenko wrote:
> Hello Jacek,
>
> > 5 вер. 2019 р. о 3:06 пп Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> написав(ла):
> >
> > Hello,
> >
> > On Thu, Sep 05, 2019 at 12:57:28PM +0300, Dan Carpenter wrote:
> >> The problem is we set "led_cdev->trigger = NULL;" and then dereference
> >> it when we call write_lock_irqsave():
> >>
> >> write_lock_irqsave(&led_cdev->trigger->leddev_list_lock, flags);
> >> ^^^^^^^^^^^^^^^^^
> >>
> >> Fixes: 2282e125a406 ("leds: triggers: let struct led_trigger::activate() return an error code")
> >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > Obviously right. Thanks for catching.
> >
> > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >
> > Did you find this at runtime or by using some static checker?
>
> Let me summarize the chronology of the last activities below:
> 1. I have sent the patch for the bugs that I have found by static analyzer at PVS-Studio
> Date: Wed, 4 Sep 2019 00:18:19 +0300
> https://www.spinics.net/lists/linux-leds/msg13181.html
>
> 2. At 5 Sep 2019 12:57:19 +0300 Time Dan Cartpen has sent the patch with the same proposal
> 3. Uwe Kleine-König started to discuss his results of review by asking Dan on how he was found it.
>
> Would you mine if you will keep me as a Original author of this patch based on fact 1?
I don't care much personally but it seems fair to take Oleh's version. I
didn't see Oleh's patch before as only Dan's was Cc:d to me.
Feel free to add my Reviewed-by also to Oleh's patch of course.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
