On 2019/9/4 18:02, Dan Carpenter wrote:
> The error handling doesn't work because "cf_name->len" is unsigned.
Dan, thanks for catching this, would you mind merging this into original patch,
since it's still in the dev branch. :)
Thanks,
>
> Fixes: fbce5d4ab3ab ("f2fs: optimize case-insensitive lookups")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> fs/f2fs/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 9de688a4e115..c83b666f9d7e 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -157,7 +157,7 @@ void f2fs_fname_setup_ci_filename(struct inode *dir,
> cf_name->len = utf8_casefold(sbi->s_encoding,
> iname, cf_name->name,
> F2FS_NAME_LEN);
> - if (cf_name->len <= 0) {
> + if ((int)cf_name->len <= 0) {
> kvfree(cf_name->name);
> cf_name->name = NULL;
> }
>
