>> The brelse() function tests whether its argument is NULL >> and then returns immediately. >> Thus the test around the call is not needed. >> >> This issue was detected by using the Coccinelle software. > > The same applies to brelse() in gfs2_dir_no_add > (which Coccinelle apparently missed), Would you like to achieve that such source code analysis will be extended to corresponding header files? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/gfs2/dir.h?id=7dc4585e03786f84d6e9dc16caa3ba5b8b44d986#n33 > so let me fix that as well. Thanks for your positive feedback. Regards, Markus
