On Thu, Aug 22, 2019 at 10:34:37PM +0800, Yuehaibing wrote: > On 2019/8/22 22:18, Maxime Ripard wrote: > > On Thu, Aug 22, 2019 at 06:52:52AM +0000, YueHaibing wrote: > >> - if (IS_ERR(i2s->field_fmt_sr)) > >> - return PTR_ERR(i2s->field_fmt_sr); > >> - > >> - return 0; > >> + return PTR_ERR_OR_ZERO(i2s->field_fmt_sr); > > I'm not really convinced that this more readable or more maintainable > > though. Is there a reason for this other than we can do it? > No special reason, just suggested by scripts/coccinelle/api/ptr_ret.cocci Which is a bit of a reason in itself since it'll save other people looking at the same thing though with a return like this I have to agree with Maxime a bit and question if the coccinelle script is really a good idea.
Attachment:
signature.asc
Description: PGP signature
