On Thu, Aug 22, 2019 at 11:11:56AM +0200, Kadlecsik József wrote: > Hi Dan, > > On Wed, 21 Aug 2019, Dan Carpenter wrote: > > > The copy_to_user() function returns the number of bytes remaining to be > > copied. In this code, that positive return is checked at the end of the > > function and we return zero/success. What we should do instead is > > return -EFAULT. > > Yes, you are right. There's another usage of copy_to_user() in this > function, could you fix it as well? > Yes, of course. Thanks for the review. regards, dan carpenter