On 22. 08. 19 10:28, Dan Carpenter wrote: > On Thu, Aug 22, 2019 at 10:14:12AM +0200, Michal Simek wrote: >> Hi Dan, >> >> On 21. 08. 19 9:06, Dan Carpenter wrote: >>> These structs have holes in them so we end up disclosing a few bytes of >>> uninitialized stack data. >>> >>> drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check that 'status' doesn't leak information (struct has a hole after 'activity') >>> drivers/misc/xilinx_sdfec.c:449 xsdfec_get_turbo() warn: check that 'turbo_params' doesn't leak information (struct has a hole after 'scale') >> >> Who is generating these warnings? Is this any new GCC or different tool? >> I see that 3byte padding but never seen these warnings. > > This is a Smatch check. ok. It looks like I need to update it to latest version. My version is not showing these. Anyway thanks for patches, Michal
