From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Wed, 21 Aug 2019 14:30:30 +0200 The dev_kfree_skb() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/staging/wlan-ng/hfa384x_usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 28d372a0663a..54f631c4155a 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -3070,9 +3070,7 @@ static void hfa384x_usbin_callback(struct urb *urb) } /* switch */ exit: - - if (skb) - dev_kfree_skb(skb); + dev_kfree_skb(skb); } /*---------------------------------------------------------------- -- 2.23.0
