There are two warnings in net/can, fix them by setting bcm_sock_no_ioctlcmd and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static? net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared. Should it be static? Fixes: 473d924d7d46 ("can: fix ioctl function removal") Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx> Acked-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx> --- v1->v2: change patch description typo error, 'warings' to 'warnings'. v2->v3: change subject of patch. v3->v4: change the alignment of two functions. net/can/bcm.c | 4 ++-- net/can/raw.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index bf1d0bbecec8..eb1d28b8c46a 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -1680,8 +1680,8 @@ static int bcm_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, return size; } -int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, - unsigned long arg) +static int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, + unsigned long arg) { /* no ioctls for socket layer -> hand it down to NIC layer */ return -ENOIOCTLCMD; diff --git a/net/can/raw.c b/net/can/raw.c index da386f1fa815..a30aaecd9327 100644 --- a/net/can/raw.c +++ b/net/can/raw.c @@ -837,8 +837,8 @@ static int raw_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, return size; } -int raw_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, - unsigned long arg) +static int raw_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, + unsigned long arg) { /* no ioctls for socket layer -> hand it down to NIC layer */ return -ENOIOCTLCMD; -- 2.20.1