> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On > Behalf Of Colin King > Sent: Friday, August 2, 2019 8:52 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; David S . Miller > <davem@xxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [Intel-wired-lan] [PATCH][net-next] ice: fix potential infinite loop > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The loop counter of a for-loop is a u8 however this is being compared to an > int upper bound and this can lead to an infinite loop if the upper bound is > greater than 255 since the loop counter will wrap back to zero. Fix this > potential issue by making the loop counter an int. > > Addresses-Coverity: ("Infinite loop") > Fixes: c7aeb4d1b9bf ("ice: Disable VFs until reset is completed") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>
