"Dan Carpenter" <dan.carpenter@xxxxxxxxxx> writes: > You're just turning off GCC's static analysis (and introducing false > positives) when you do that. We have seen bugs caused by this and never > seen any bugs prevented by this style. You've never seen bugs prevented by initializing uninitialized variables? Code can change overtime and I don't think coverity is checked as often as it could be, meaning the var could end up being used while uninitialized in the future. Anyway I won't die on this hill, merge this if you prefer. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
