On 30/07/2019 12:12, Petr Machata wrote:
>
> Petr Machata <petrm@xxxxxxxxxxxx> writes:
>
>> Colin King <colin.king@xxxxxxxxxxxxx> writes:
>>
>>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>>
>>> Currently there is a duplicated check on orig_egr_types which is
>>> redundant, I believe this is a typo and should actually be
>>> orig_ing_types || orig_egr_types instead of the expression
>>> orig_egr_types || orig_egr_types. Fix this.
>>
>> Good catch, yes, there's a typo. Thanks for the fix!
>>
>>> Addresses-Coverity: ("Same on both sides")
>>> Fixes: c6b36bdd04b5 ("mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled")
>>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> Reviewed-by: Petr Machata <petrm@xxxxxxxxxxxx>
>
> I see that there is an identical problem in the code one block further.
> Can you take care of that as well, please? Or should I do it?
>
I'll sort that out too
