-----"Wei Yongjun" <weiyongjun1@xxxxxxxxxx> wrote: ----- >To: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx>, "Doug Ledford" ><dledford@xxxxxxxxxx>, "Jason Gunthorpe" <jgg@xxxxxxxx> >From: "Wei Yongjun" <weiyongjun1@xxxxxxxxxx> >Date: 07/18/2019 11:21AM >Cc: "Wei Yongjun" <weiyongjun1@xxxxxxxxxx>, ><linux-rdma@xxxxxxxxxxxxxxx>, <kernel-janitors@xxxxxxxxxxxxxxx> >Subject: [EXTERNAL] [PATCH] RDMA/siw: fix error return code in >siw_init_module() > >Fix to return a negative error code from the error handling >case instead of 0, as done elsewhere in this function. > >Fixes: bdcf26bf9b3a ("rdma/siw: network and RDMA core interface") >Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> >--- > drivers/infiniband/sw/siw/siw_main.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/infiniband/sw/siw/siw_main.c >b/drivers/infiniband/sw/siw/siw_main.c >index fd2552a9091d..9040692f83d7 100644 >--- a/drivers/infiniband/sw/siw/siw_main.c >+++ b/drivers/infiniband/sw/siw/siw_main.c >@@ -614,6 +614,7 @@ static __init int siw_init_module(void) > > if (!siw_create_tx_threads()) { > pr_info("siw: Could not start any TX thread\n"); >+ rv = -ENOMEM; > goto out_error; > } > /* > > > > Yes, thanks Wei! Bernard.