Thanks Yue, looks good to me. Nick On Fri, Jun 21, 2019 at 7:59 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > > Use kmemdup rather than duplicating its implementation > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > drivers/platform/chrome/wilco_ec/event.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c > index c975b76e6255..70156e75047e 100644 > --- a/drivers/platform/chrome/wilco_ec/event.c > +++ b/drivers/platform/chrome/wilco_ec/event.c > @@ -248,10 +248,9 @@ static int enqueue_events(struct acpi_device *adev, const u8 *buf, u32 length) > offset += event_size; > > /* Copy event into the queue */ > - queue_event = kzalloc(event_size, GFP_KERNEL); > + queue_event = kmemdup(event, event_size, GFP_KERNEL); > if (!queue_event) > return -ENOMEM; > - memcpy(queue_event, event, event_size); > event_queue_push(dev_data->events, queue_event); > } > > >
