Re: [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Markus Elfring <Markus.Elfring@xxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
Subject: Re: [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions
From: "Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx>
Date: Mon, 17 Jun 2019 22:21:06 +0200
Cc: cocci@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>, Gilles Muller <Gilles.Muller@xxxxxxx>, Himanshu Jha <himanshujha199640@xxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Michal Marek <michal.lkml@xxxxxxxxxxx>, Nicolas Palix <nicolas.palix@xxxxxxx>
In-reply-to: <032e347f-e575-c89c-fa62-473d52232735@web.de>
Organization: metux IT consult
References: <20190406061112.31620-1-himanshujha199640@gmail.com> <f09006a3-691c-382a-23b8-8e9ff5b4a5f1@web.de> <alpine.DEB.2.21.1906081925090.2543@hadrien> <7b4fe770-dadd-80ba-2ba4-0f2bc90984ef@web.de> <f573b2d3-11d0-92b5-f8ab-4c4b6493e152@metux.net> <032e347f-e575-c89c-fa62-473d52232735@web.de>
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 14.06.19 11:22, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Fri, 14 Jun 2019 11:05:33 +0200
> 
> Two function calls were combined in this function implementation.
> Inline corresponding code so that extra error checks can be avoided here.

What exactly is the purpose of this ?

Looks like a notable code duplication ... I thought we usually try to
reduce this, instead of introducing new ones.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287

Follow-Ups:
- Re: drivers: Inline code in devm_platform_ioremap_resource() from two functions
  - From: Markus Elfring

References:
- [PATCH] coccinelle: api: add devm_platform_ioremap_resource script
  - From: Himanshu Jha
- Re: Coccinelle: api: add devm_platform_ioremap_resource script
  - From: Markus Elfring
- Re: Coccinelle: api: add devm_platform_ioremap_resource script
  - From: Julia Lawall
- Re: Coccinelle: api: add devm_platform_ioremap_resource script
  - From: Markus Elfring
- Re: Coccinelle: api: add devm_platform_ioremap_resource script
  - From: Enrico Weigelt, metux IT consult
- [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions
  - From: Markus Elfring

Prev by Date: [PATCH] lib: devres: devm_ioremap_resource() make res parameter const
Next by Date: Re: [PATCH][next] net: hns3: fix dereference of ae_dev before it is null checked
Previous by thread: Re: [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions
Next by thread: Re: drivers: Inline code in devm_platform_ioremap_resource() from two functions
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]