RE: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Colin King <colin.king@xxxxxxxxxxxxx>
Subject: RE: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy
From: Ganapathi Bhat <gbhat@xxxxxxxxxxx>
Date: Sat, 1 Jun 2019 17:29:26 +0000
Accept-language: en-US
Cc: Amitkumar Karwar <amitkarwar@xxxxxxxxx>, Nishant Sarmukadam <nishants@xxxxxxxxxxx>, Xinming Hu <huxinming820@xxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, "linux-wireless@xxxxxxxxxxxxxxx" <linux-wireless@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20190413192729.GL6095@kadam>
References: <20190413161438.6376-1-colin.king@canonical.com> <20190413192729.GL6095@kadam>

Hi Dan,

> >  	if (is_multicast_ether_addr(ra)) {
> >  		skb_uap = skb_copy(skb, GFP_ATOMIC);
> > +		if (!skb_uap)
> > +			return -ENOMEM;
> 
> I think we would want to free dev_kfree_skb_any(skb) before returning.
I think if the pointer is NULL, no need to free it; 

Regards,
Ganapathi

Follow-Ups:
- Re: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy
  - From: Dan Carpenter

References:
- [PATCH] mwifiex: check for null return from skb_copy
  - From: Colin King
- Re: [PATCH] mwifiex: check for null return from skb_copy
  - From: Dan Carpenter

Prev by Date: Re: [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm'
Next by Date: Re: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy
Previous by thread: Re: [PATCH] mwifiex: check for null return from skb_copy
Next by thread: Re: [EXT] Re: [PATCH] mwifiex: check for null return from skb_copy
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]