Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Date: Wed, 22 May 2019 11:00:04 +0100
Cc: Dan Murphy <dmurphy@xxxxxx>, Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, linux-leds@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20190522095317.GT31203@kadam>
Openpgp: preference=signencrypt
References: <20190522082627.18354-1-colin.king@canonical.com> <20190522095317.GT31203@kadam>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 22/05/2019 10:53, Dan Carpenter wrote:
> No.  This isn't the right fix.  We should declare them as int instead.

Doh, brown paper bag time. I'll do a V2.

> 
> regards,
> dan carpenter
>

References:
- [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero
  - From: Colin King
- Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero
  - From: Dan Carpenter

Prev by Date: Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero
Next by Date: [PATCH][V2] leds: TI LMU: fix u8 variable comparisons with less than zero
Previous by thread: Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero
Next by thread: [PATCH][next] scsi: hpsa: fix an uninitialized read and dereference of pointer dev
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux