On 09-05-19, 13:09, Dan Carpenter wrote: > The mtk_cqdma_poll_engine_done() function takes a true/false parameter > where true means it's called from atomic context. There are a couple > places where it was set to false but it's actually in atomic context > so it should be true. > > All the callers for mtk_cqdma_hard_reset() are holding a spin_lock and > in mtk_cqdma_free_chan_resources() we take a spin_lock before calling > the mtk_cqdma_poll_engine_done() function. Applied, thanks > > Fixes: b1f01e48df5a ("dmaengine: mediatek: Add MediaTek Command-Queue DMA controller for MT6765 SoC") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > The "atomic" parameter is always true so the temptation was to just > remove it entirely. a patch is welcome :) -- ~Vinod